report abstract as extraneous modifier

report abstract as extraneous modifier

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/059e877d23f88a065441db6c7f05ead4e79c7735

[danrubel, 2017-08-27 15:59:43]

danrubel@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-08-28 11:14:08]

I would like to see a test that exercises this outside analyzer unit tests.
Otherwise, LGTM!

If you like, you can add the non-analyzer tests in a separate CL.

https://codereview.chromium.org/3004683002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/3004683002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:2152: // abstract
Consider this instead of the comment:

assert(optional("abstract", token))

https://codereview.chromium.org/3004683002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:2154: token,
fasta.templateExtraneousModifier);
Should this be a new error code so it's easier to distinguish them in the
analyzer?

[danrubel, 2017-08-29 14:58:47]

https://codereview.chromium.org/3004683002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/3004683002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:2152: // abstract
On 2017/08/28 11:14:08, ahe wrote:
> Consider this instead of the comment:
> 
> assert(optional("abstract", token))

Good idea. Done.

https://codereview.chromium.org/3004683002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:2154: token,
fasta.templateExtraneousModifier);
On 2017/08/28 11:14:08, ahe wrote:
> Should this be a new error code so it's easier to distinguish them in the
> analyzer?

I need to create a separate error code to distinguish 'abstract' on class
members. I'll address that in a separate CL.

[danrubel, 2017-08-29 15:00:40]

Description was changed from

==========
report abstract as extraneous modifier
==========

to

==========
report abstract as extraneous modifier

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/059e877d23f88a065441db6c7f05ead4e79c7735
==========

[danrubel, 2017-08-29 15:00:42]

Committed patchset #3 (id:40001) manually as
059e877d23f88a065441db6c7f05ead4e79c7735 (presubmit successful).