Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 3004643002: Follow up fixes on handling of exports (Closed)

Created:
3 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 3 months ago
Reviewers:
Johnni Winther, ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Follow up fixes on handling of exports Basically the suggestions from Johnni in the previous CL.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Siggi Cherem (dart-lang)
3 years, 3 months ago (2017-08-25 22:52:40 UTC) #4
Johnni Winther
lgtm
3 years, 3 months ago (2017-08-28 06:54:51 UTC) #5
ahe
I'll try to close this, as I've landed CL 3003993002.
3 years, 3 months ago (2017-08-28 11:52:35 UTC) #6
Siggi Cherem (dart-lang)
3 years, 3 months ago (2017-08-28 16:03:18 UTC) #7
Message was sent while issue was closed.
thanks Peter!

Powered by Google App Engine
This is Rietveld 408576698