Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 3004613002: Add support for highlights notification (Closed)

Created:
3 years, 3 months ago by Brian Wilkerson
Modified:
3 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+425 lines, -1 line) Patch
A pkg/analyzer_plugin/doc/tutorial/highlights.md View 1 chunk +89 lines, -0 lines 2 comments Download
M pkg/analyzer_plugin/doc/tutorial/outline.md View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analyzer_plugin/lib/plugin/highlights_mixin.dart View 1 chunk +68 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/src/utilities/highlights/highlights.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/utilities/highlights/highlights.dart View 1 chunk +116 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/plugin/highlights_mixin_test.dart View 1 chunk +100 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/plugin/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 3 months ago (2017-08-25 16:08:49 UTC) #2
scheglov
LGTM https://codereview.chromium.org/3004613002/diff/1/pkg/analyzer_plugin/doc/tutorial/highlights.md File pkg/analyzer_plugin/doc/tutorial/highlights.md (right): https://codereview.chromium.org/3004613002/diff/1/pkg/analyzer_plugin/doc/tutorial/highlights.md#newcode46 pkg/analyzer_plugin/doc/tutorial/highlights.md:46: implement the method `computeOutline`. This method is typically ...
3 years, 3 months ago (2017-08-25 16:15:42 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/3004613002/diff/1/pkg/analyzer_plugin/doc/tutorial/highlights.md File pkg/analyzer_plugin/doc/tutorial/highlights.md (right): https://codereview.chromium.org/3004613002/diff/1/pkg/analyzer_plugin/doc/tutorial/highlights.md#newcode46 pkg/analyzer_plugin/doc/tutorial/highlights.md:46: implement the method `computeOutline`. This method is typically implemented ...
3 years, 3 months ago (2017-08-25 16:21:24 UTC) #4
Brian Wilkerson
3 years, 3 months ago (2017-08-25 16:21:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd00fc7750313ae8ad8ffd62d42bdb67ff491adc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698