Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: pkg/compiler/lib/src/dart2js.dart

Issue 3004593002: Support enabling of type inference with useKernel (Closed)
Patch Set: Updated cf. comment Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/dart2js.dart
diff --git a/pkg/compiler/lib/src/dart2js.dart b/pkg/compiler/lib/src/dart2js.dart
index 34c0a996466a742b6c114314c00a78b7ca63c2bc..10f76ebae3a81ed4802ef64b538113570463bb56 100644
--- a/pkg/compiler/lib/src/dart2js.dart
+++ b/pkg/compiler/lib/src/dart2js.dart
@@ -278,8 +278,12 @@ Future<api.CompilationResult> compile(List<String> argv) {
passThrough('--categories=${categories.join(",")}');
}
- void setPreviewDart2(String argument) {
+ void setUseKernel(String argument) {
useKernel = true;
+ // TODO(sigmund): remove once we support inlining and type-inference
+ // with `useKernel`.
+ options.add(Flags.disableInlining);
+ options.add(Flags.disableTypeInference);
passThrough(argument);
}
@@ -335,7 +339,7 @@ Future<api.CompilationResult> compile(List<String> argv) {
// implemented.
new OptionHandler(Flags.kernelGlobalInference, passThrough),
new OptionHandler(Flags.useKernelInSsa, passThrough),
- new OptionHandler(Flags.useKernel, setPreviewDart2),
+ new OptionHandler(Flags.useKernel, setUseKernel),
new OptionHandler(Flags.noFrequencyBasedMinification, passThrough),
new OptionHandler(Flags.verbose, setVerbose),
new OptionHandler(Flags.version, (_) => wantVersion = true),
« no previous file with comments | « no previous file | pkg/compiler/lib/src/options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698