Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Issue 3004593002: Support enabling of type inference with useKernel (Closed)

Created:
3 years, 3 months ago by Johnni Winther
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -14 lines) Patch
M pkg/compiler/lib/src/dart2js.dart View 1 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/options.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/closure/closure_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/equivalence/id_equivalence_helper.dart View 4 chunks +6 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/equivalence/id_equivalence_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/jumps/jump_test.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 3 months ago (2017-08-25 08:33:28 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/3004593002/diff/1/pkg/compiler/lib/src/dart2js.dart File pkg/compiler/lib/src/dart2js.dart (right): https://codereview.chromium.org/3004593002/diff/1/pkg/compiler/lib/src/dart2js.dart#newcode281 pkg/compiler/lib/src/dart2js.dart:281: void setPreviewDart2(String argument) { my fault, when I ...
3 years, 3 months ago (2017-08-25 14:45:46 UTC) #3
Johnni Winther
https://codereview.chromium.org/3004593002/diff/1/pkg/compiler/lib/src/dart2js.dart File pkg/compiler/lib/src/dart2js.dart (right): https://codereview.chromium.org/3004593002/diff/1/pkg/compiler/lib/src/dart2js.dart#newcode281 pkg/compiler/lib/src/dart2js.dart:281: void setPreviewDart2(String argument) { On 2017/08/25 14:45:46, Siggi Cherem ...
3 years, 3 months ago (2017-08-25 16:50:41 UTC) #4
Johnni Winther
3 years, 3 months ago (2017-08-25 16:57:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0b643a69c48f87e1c2d5367c37aeb6f4b2d129a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698