Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 3004573002: remove old fasta missing exponent recovery (Closed)

Created:
3 years, 4 months ago by danrubel
Modified:
3 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

remove old fasta missing exponent recovery As of https://codereview.chromium.org/3002493003 fasta recovers from a missing exponent by first issuing an error and then appending '0' to the number so that 347e becomes 347e0 This CL removes the old error recovery that appends NaN to the token stream as it is no longer needed. Fix https://github.com/dart-lang/sdk/issues/30508 R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/07a00fc2589d6c64249f5e7a184ae38d9cf98d68

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M pkg/front_end/lib/src/fasta/scanner/recover.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/test/scanner_replacement_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
danrubel
3 years, 4 months ago (2017-08-24 21:27:59 UTC) #2
scheglov
lgtm
3 years, 4 months ago (2017-08-24 21:52:03 UTC) #4
danrubel
3 years, 3 months ago (2017-08-25 12:57:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
07a00fc2589d6c64249f5e7a184ae38d9cf98d68 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698