Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: runtime/vm/heap.cc

Issue 3004563003: Refactor Isolate name format, storage and log (Closed)
Patch Set: Make Dart_DebugName unique again Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/heap.cc
diff --git a/runtime/vm/heap.cc b/runtime/vm/heap.cc
index 6f5149707890f6957f98faf676bf7322b02af712..3dff3e08be95d5775d03ad9d9d257fd6448ec263 100644
--- a/runtime/vm/heap.cc
+++ b/runtime/vm/heap.cc
@@ -550,17 +550,10 @@ void Heap::Init(Isolate* isolate,
}
void Heap::RegionName(Heap* heap, Space space, char* name, intptr_t name_size) {
-#if defined(PRODUCT)
const bool no_isolate_name = (heap == NULL) || (heap->isolate() == NULL) ||
(heap->isolate()->name() == NULL);
const char* isolate_name =
no_isolate_name ? "<unknown>" : heap->isolate()->name();
-#else
- const bool no_isolate_name = (heap == NULL) || (heap->isolate() == NULL) ||
- (heap->isolate()->debugger_name() == NULL);
- const char* isolate_name =
- no_isolate_name ? "<unknown>" : heap->isolate()->debugger_name();
-#endif // !defined(PRODUCT)
const char* space_name = NULL;
switch (space) {
case kNew:
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698