Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: pkg/analysis_server/lib/src/server/driver.dart

Issue 3004523003: Remove more references to the old plugin system (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/analysis_server.dart ('k') | pkg/analysis_server/lib/src/socket_server.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/server/driver.dart
diff --git a/pkg/analysis_server/lib/src/server/driver.dart b/pkg/analysis_server/lib/src/server/driver.dart
index 1067ef5c290173dbbaefa869730e846b3b224cb8..86b2239882f11c23dab6d5904470c425e148418d 100644
--- a/pkg/analysis_server/lib/src/server/driver.dart
+++ b/pkg/analysis_server/lib/src/server/driver.dart
@@ -23,7 +23,6 @@ import 'package:analyzer/src/generated/sdk.dart';
import 'package:args/args.dart';
import 'package:linter/src/rules.dart' as linter;
import 'package:plugin/manager.dart';
-import 'package:plugin/plugin.dart';
import 'package:telemetry/crash_reporting.dart';
import 'package:telemetry/telemetry.dart' as telemetry;
@@ -267,11 +266,6 @@ class Driver implements ServerStarter {
*/
ResolverProvider packageResolverProvider;
- /**
- * The plugins that are defined outside the analysis_server package.
- */
- List<Plugin> _userDefinedPlugins = <Plugin>[];
-
SocketServer socketServer;
HttpAnalysisServer httpServer;
@@ -281,13 +275,6 @@ class Driver implements ServerStarter {
Driver();
/**
- * Set the [plugins] that are defined outside the analysis_server package.
- */
- void set userDefinedPlugins(List<Plugin> plugins) {
- _userDefinedPlugins = plugins ?? <Plugin>[];
- }
-
- /**
* Use the given command-line [arguments] to start this server.
*
* At least temporarily returns AnalysisServer so that consumers of the
@@ -355,11 +342,8 @@ class Driver implements ServerStarter {
//
// Process all of the plugins so that extensions are registered.
//
- List<Plugin> plugins = <Plugin>[];
- plugins.addAll(AnalysisEngine.instance.requiredPlugins);
- plugins.addAll(_userDefinedPlugins);
ExtensionManager manager = new ExtensionManager();
- manager.processPlugins(plugins);
+ manager.processPlugins(AnalysisEngine.instance.requiredPlugins);
linter.registerLintRules();
String defaultSdkPath;
@@ -417,7 +401,6 @@ class Driver implements ServerStarter {
packageResolverProvider);
httpServer = new HttpAnalysisServer(socketServer);
stdioServer = new StdioAnalysisServer(socketServer);
- socketServer.userDefinedPlugins = _userDefinedPlugins;
diagnosticServer.httpServer = httpServer;
if (serve_http) {
« no previous file with comments | « pkg/analysis_server/lib/src/analysis_server.dart ('k') | pkg/analysis_server/lib/src/socket_server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698