Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3004453002: Fix `Function.apply` dartdoc. (Closed)

Created:
3 years, 3 months ago by floitsch
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M sdk/lib/core/function.dart View 1 chunk +9 lines, -5 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
The dartdoc didn't look correct. TBR.
3 years, 3 months ago (2017-08-22 17:03:58 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as 5cc2a9bc04b5b43204aee8201b8cea1f54d56f31 (presubmit successful).
3 years, 3 months ago (2017-08-22 17:04:14 UTC) #4
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/3004453002/diff/1/sdk/lib/core/function.dart File sdk/lib/core/function.dart (right): https://codereview.chromium.org/3004453002/diff/1/sdk/lib/core/function.dart#newcode30 sdk/lib/core/function.dart:30: * ``` How about just doing: Function.apply(foo, [1, ...
3 years, 3 months ago (2017-08-23 05:53:31 UTC) #5
floitsch
3 years, 3 months ago (2017-08-23 18:09:00 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/3004453002/diff/1/sdk/lib/core/function.dart
File sdk/lib/core/function.dart (right):

https://codereview.chromium.org/3004453002/diff/1/sdk/lib/core/function.dart#...
sdk/lib/core/function.dart:30: * ```
On 2017/08/23 05:53:31, Lasse Reichstein Nielsen wrote:
> How about just doing:
> 
>   Function.apply(foo, [1, 2, 3], {#f: 4, #g: 5});
> 
> and drop the imperative map creation?

done in https://codereview.chromium.org/3002193002

Powered by Google App Engine
This is Rietveld 408576698