Encapsulate the index based maps for entities.

Encapsulate the index based maps for entities.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/5d96c36a4af66d0265ef443419c8aa464607a508

[Johnni Winther, 2017-08-22 13:56:11]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-08-22 19:12:22]

short reply (still ooo, will look in more detail tomorrow, but some early
comments below)

https://codereview.chromium.org/3004433002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/3004433002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:1986: }, (IndexedClass cls) {
I'd use => for these short closures here and elsewhere:

...,
(_) => data.copy(),
(_) => env);

https://codereview.chromium.org/3004433002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/env.dart (right):

https://codereview.chromium.org/3004433002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/env.dart:52: D getData(int index) {
what about making a generic Indexable interface and make E extend from it?

Then you can do:
  getData(member);

and you retrieve and set the index here.

You can even make the field private to this library by declaring the interface
here.

https://codereview.chromium.org/3004433002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/env.dart:106: E0 createEntity(int index),
can we switch to take the actual values instead of a closure?

   register(E0 entity, D0 data, V0 env)

I think it will make the use site of this API simpler.

I believe it will be easier we change to have _index private to this library and
set it after we create the entity (here on registration). Each caller can use
the entity when building the data/env, but I noticed many callsites won't need
it anyways.

[Johnni Winther, 2017-09-01 17:47:17]

PTAL

Added an Indexed interface.

[Siggi Cherem (dart-lang), 2017-09-01 17:58:24]

lgtm

very nice, thank you

[Johnni Winther, 2017-09-01 18:16:00]

Description was changed from

==========
Encapsulate the index based maps for entities.
==========

to

==========
Encapsulate the index based maps for entities.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5d96c36a4af66d0265ef443419c8aa464607a508
==========

[Johnni Winther, 2017-09-01 18:16:01]

Committed patchset #2 (id:20001) manually as
5d96c36a4af66d0265ef443419c8aa464607a508 (presubmit successful).

[Emily Fortuna, 2017-09-01 19:20:33]

efortuna@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-09-01 19:20:34]

yay!