Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Issue 300433003: Code cleanup (Closed)

Created:
6 years, 7 months ago by sdefresne
Modified:
6 years, 7 months ago
Reviewers:
blundell
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Code cleanup 1) Fix a typo in ScoredHistoryMatch::GetFrequency name 2) Fix a cpplint warning BUG=370850 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M chrome/browser/history/scored_history_match.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/history/scored_history_match.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/history/url_index_private_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sdefresne
Please have a look.
6 years, 7 months ago (2014-05-23 08:45:01 UTC) #1
blundell
lgtm
6 years, 7 months ago (2014-05-26 06:59:20 UTC) #2
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 7 months ago (2014-05-26 08:20:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/300433003/1
6 years, 7 months ago (2014-05-26 08:20:45 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 11:03:19 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 20:16:11 UTC) #6
Message was sent while issue was closed.
Change committed as 272875

Powered by Google App Engine
This is Rietveld 408576698