Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: pkg/analysis_server/lib/src/services/correction/fix_internal.dart

Issue 3004293002: Add fixes for two more lint rules (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/correction/fix_internal.dart
diff --git a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
index 76163cb0d3cc259ced60ce71de64d195e22b2f3a..4acfd62dcedc86186e418fb9b8422d2ff5a1a586 100644
--- a/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
+++ b/pkg/analysis_server/lib/src/services/correction/fix_internal.dart
@@ -429,6 +429,12 @@ class FixProcessor {
if (name == LintNames.await_only_futures) {
await _addFix_removeAwait();
}
+ if (name == LintNames.empty_catches) {
+ await _addFix_removeEmptyCatch();
+ }
+ if (name == LintNames.empty_constructor_bodies) {
+ await _addFix_removeEmptyConstructorBody();
+ }
if (name == LintNames.empty_statements) {
await _addFix_removeEmptyStatement();
}
@@ -1938,6 +1944,24 @@ class FixProcessor {
}
}
+ Future<Null> _addFix_removeEmptyCatch() async {
+ DartChangeBuilder changeBuilder = new DartChangeBuilder(session);
+ await changeBuilder.addFileEdit(file, (DartFileEditBuilder builder) {
+ builder.addDeletion(utils.getLinesRange(range.node(node.parent)));
+ });
+ _addFixFromBuilder(changeBuilder, DartFixKind.REMOVE_EMPTY_CATCH);
+ }
+
+ Future<Null> _addFix_removeEmptyConstructorBody() async {
+ DartChangeBuilder changeBuilder = new DartChangeBuilder(session);
+ await changeBuilder.addFileEdit(file, (DartFileEditBuilder builder) {
+ builder.addSimpleReplacement(
+ utils.getLinesRange(range.node(node.parent)), ';');
+ });
+ _addFixFromBuilder(
+ changeBuilder, DartFixKind.REMOVE_EMPTY_CONSTRUCTOR_BODY);
+ }
+
Future<Null> _addFix_removeEmptyElse() async {
IfStatement ifStatement = node.parent;
DartChangeBuilder changeBuilder = new DartChangeBuilder(session);
@@ -3174,6 +3198,8 @@ class LintNames {
static const String avoid_types_on_closure_parameters =
'avoid_types_on_closure_parameters';
static const String await_only_futures = 'await_only_futures';
+ static const String empty_catches = 'empty_catches';
+ static const String empty_constructor_bodies = 'empty_constructor_bodies';
static const String empty_statements = 'empty_statements';
static const String prefer_collection_literals = 'prefer_collection_literals';
static const String prefer_conditional_assignment =
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/fix.dart ('k') | pkg/analysis_server/test/services/correction/fix_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698