Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 3004273002: Dart Kythe indexer refactoring to gather all variable declaration logic into one method (Closed)

Created:
3 years, 3 months ago by jwren
Modified:
3 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Dart Kythe indexer refactoring to gather all variable declaration logic into one method R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/8f1b6d0aab6bb5b774bd2c466064a9ccf93f288a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -50 lines) Patch
M pkg/analysis_server/lib/src/services/kythe/kythe_visitors.dart View 4 chunks +28 lines, -50 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jwren
3 years, 3 months ago (2017-09-01 18:54:38 UTC) #2
Brian Wilkerson
lgtm
3 years, 3 months ago (2017-09-01 19:07:07 UTC) #3
jwren
3 years, 3 months ago (2017-09-01 19:12:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f1b6d0aab6bb5b774bd2c466064a9ccf93f288a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698