Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 3004243002: Test whether DDC sdk is up-to-date (Closed)

Created:
3 years, 3 months ago by vsm
Modified:
3 years, 3 months ago
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test whether DDC sdk is up-to-date Patch 1 run with out-of-date SDK: https://travis-ci.org/dart-lang/sdk/builds/270847032 Patch 2 run with updated SDK: https://travis-ci.org/dart-lang/sdk/builds/270849435 I've moved all browser runs to Allowed Failures as we're rely on chrome bots for green. R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/181433a8d309816fd522382c63808bb2df8e5297

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -65 lines) Patch
M .travis.yml View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 3 months ago (2017-09-01 14:32:13 UTC) #3
Jennifer Messerly
lgtm
3 years, 3 months ago (2017-09-01 19:44:26 UTC) #4
vsm
3 years, 3 months ago (2017-09-01 20:23:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
181433a8d309816fd522382c63808bb2df8e5297 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698