Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3004173002: Revert "Removed Dartium SDK libs" (Closed)

Created:
3 years, 3 months ago by Bill Hesse
Modified:
3 years, 3 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, zra, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Removed Dartium SDK libs" This reverts commit 4a5891838274ac53124acf6905c8ac9121978470. That commit seems to have broken docgen on the html libraries. BUG= TBR=terry@google.com Committed: https://github.com/dart-lang/sdk/commit/a8cab7a2055e5113a9f2c2a89490a4bbe9e616db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27895 lines, -48 lines) Patch
M pkg/analyzer/lib/src/summary/summary_file_builder.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/libraries.dart View 4 chunks +17 lines, -17 lines 0 comments Download
M runtime/bin/BUILD.gn View 10 chunks +34 lines, -9 lines 0 comments Download
M runtime/bin/builtin.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/builtin.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/lib/mirrors.cc View 1 chunk +1 line, -1 line 0 comments Download
M sdk/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A sdk/lib/_chrome/dartium/chrome_dartium.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart View 4 chunks +21 lines, -16 lines 0 comments Download
A sdk/lib/html/html_common/conversions_dartium.dart View 1 chunk +294 lines, -0 lines 0 comments Download
M sdk/lib/html/html_common/html_common.dart View 2 chunks +1 line, -2 lines 0 comments Download
A sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 1 chunk +1467 lines, -0 lines 0 comments Download
A sdk/lib/js/dartium/cached_patches.dart View 1 chunk +6270 lines, -0 lines 0 comments Download
A sdk/lib/js/dartium/js_dartium.dart View 1 chunk +1706 lines, -0 lines 0 comments Download
A sdk/lib/js_util/dartium/js_util_dartium.dart View 1 chunk +40 lines, -0 lines 0 comments Download
A sdk/lib/svg/dartium/svg_dartium.dart View 1 chunk +7420 lines, -0 lines 0 comments Download
A sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 chunk +1740 lines, -0 lines 0 comments Download
A sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 chunk +8465 lines, -0 lines 0 comments Download
A sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 chunk +392 lines, -0 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/wrapping_collections_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/analyzer/analyze_library.status View 1 chunk +1 line, -0 lines 0 comments Download
M tools/patch_sdk.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
The reverted CL seems to be breaking docgen on the html libraries.
3 years, 3 months ago (2017-08-31 22:46:34 UTC) #1
Bill Hesse
Committed patchset #1 (id:1) manually as a8cab7a2055e5113a9f2c2a89490a4bbe9e616db (presubmit successful).
3 years, 3 months ago (2017-08-31 22:48:04 UTC) #3
Bill Hesse
3 years, 3 months ago (2017-08-31 23:35:48 UTC) #4
Message was sent while issue was closed. 
On 2017/08/31 22:48:04, Bill Hesse wrote:
> Committed patchset #1 (id:1) manually as
> a8cab7a2055e5113a9f2c2a89490a4bbe9e616db (presubmit successful).

We also need to revert 704de3bb3e27313c0eb6eb5ebc03173a5396dd1e which is a
followup to the CL this reverts.

Powered by Google App Engine
This is Rietveld 408576698