Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3004153002: Fixed analyzer test to use dart2js not dartium (Closed)

Created:
3 years, 3 months ago by terry
Modified:
3 years, 3 months ago
Reviewers:
vsm, Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Removed rest of dartium files. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -27897 lines) Patch
M pkg/analyzer/lib/src/summary/summary_file_builder.dart View 1 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/libraries.dart View 1 4 chunks +17 lines, -17 lines 1 comment Download
M runtime/bin/BUILD.gn View 1 10 chunks +9 lines, -34 lines 0 comments Download
M runtime/bin/builtin.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/bin/builtin.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/lib/mirrors.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D sdk/lib/_chrome/dartium/chrome_dartium.dart View 1 1 chunk +0 lines, -15 lines 0 comments Download
M sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart View 1 4 chunks +16 lines, -21 lines 0 comments Download
D sdk/lib/html/html_common/conversions_dartium.dart View 1 1 chunk +0 lines, -294 lines 0 comments Download
M sdk/lib/html/html_common/html_common.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
D sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 1 1 chunk +0 lines, -1467 lines 0 comments Download
D sdk/lib/js/dartium/cached_patches.dart View 1 1 chunk +0 lines, -6270 lines 0 comments Download
D sdk/lib/js/dartium/js_dartium.dart View 1 1 chunk +0 lines, -1706 lines 0 comments Download
D sdk/lib/js_util/dartium/js_util_dartium.dart View 1 1 chunk +0 lines, -40 lines 0 comments Download
D sdk/lib/svg/dartium/svg_dartium.dart View 1 1 chunk +0 lines, -7420 lines 0 comments Download
D sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 1 chunk +0 lines, -1740 lines 0 comments Download
D sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 1 chunk +0 lines, -8465 lines 0 comments Download
D sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 1 chunk +0 lines, -392 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/html/wrapping_collections_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/analyzer/analyze_library.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/patch_sdk.dart View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
terry
Committed patchset #1 (id:1) manually as 704de3bb3e27313c0eb6eb5ebc03173a5396dd1e (presubmit successful).
3 years, 3 months ago (2017-08-31 19:25:38 UTC) #2
Paul Berry
lgtm
3 years, 3 months ago (2017-08-31 20:14:27 UTC) #3
terry
Committed patchset #2 (id:20001) manually as 0585e74b63ecd7a62ec2d6766f8d8f007d8949fa (presubmit successful).
3 years, 3 months ago (2017-09-01 16:03:27 UTC) #5
vsm
3 years, 3 months ago (2017-09-01 20:26:05 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/3004153002/diff/20001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/libraries.dart (right):

https://codereview.chromium.org/3004153002/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/libraries.dart:116: "svg": const
LibraryInfo("svg/dart2js/svg_dart2js.dart.dart",
The '.dart.dart' here is breaking DDC.

Powered by Google App Engine
This is Rietveld 408576698