Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 3004123002: Don't re-export hidden members. (Closed)

Created:
3 years, 3 months ago by ahe
Modified:
3 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, aam
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Move testing.json to own CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 1 chunk +1 line, -2 lines 0 comments Download
A pkg/front_end/test/fasta/reexport_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
3 years, 3 months ago (2017-08-31 11:56:37 UTC) #2
ahe
Note: I moved the changes to testing.json to its own CL.
3 years, 3 months ago (2017-08-31 12:56:48 UTC) #3
Johnni Winther
lgtm
3 years, 3 months ago (2017-08-31 13:16:00 UTC) #4
ahe
3 years, 3 months ago (2017-08-31 14:45:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
24ec5691d034bbb097986ccdb647b7e2b6452fbe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698