Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 3004113002: Revert "Add a hint on static uses of fuzzy arrows." (Closed)

Created:
3 years, 3 months ago by karlklose
Modified:
3 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add a hint on static uses of fuzzy arrows." This reverts commit 1f7c0d2c4c511956cacb72d528372c7cabb2ac1e. TBR=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/d7a6ef9f6493324bca02235b94fac4ba90cc892f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -61 lines) Patch
M pkg/analyzer/lib/error/error.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/error/hint_codes.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 10 chunks +5 lines, -17 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 3 chunks +1 line, -22 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
karlklose
3 years, 3 months ago (2017-08-31 06:30:08 UTC) #1
karlklose
Committed patchset #1 (id:1) manually as d7a6ef9f6493324bca02235b94fac4ba90cc892f (presubmit successful).
3 years, 3 months ago (2017-08-31 06:30:28 UTC) #3
Johnni Winther
lgtm
3 years, 3 months ago (2017-08-31 07:01:27 UTC) #4
Leaf
3 years, 3 months ago (2017-08-31 16:40:53 UTC) #5
Message was sent while issue was closed.
On 2017/08/31 07:01:27, Johnni Winther wrote:
> lgtm

Sorry for the breakage, thanks for fixing.

Powered by Google App Engine
This is Rietveld 408576698