Issue 3004103002: Fix more of the Fasta tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3004103002: Fix more of the Fasta tests (Closed)

Created:
3 years, 3 months ago by Brian Wilkerson

Modified:
3 years, 3 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix more of the Fasta tests R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/6c67db11cf0a006de9067020534171cf1898284a

Patch Set 2 : add comment #

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -250 lines)			Patch
M	pkg/analyzer/lib/src/fasta/ast_builder.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/parser_fasta_test.dart	View		12 chunks	+75 lines, -209 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_test.dart	View		2 chunks	+40 lines, -40 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

https://codereview.chromium.org/3004103002/diff/1/pkg/analyzer/test/generated/parser_test.dart File pkg/analyzer/test/generated/parser_test.dart (right): https://codereview.chromium.org/3004103002/diff/1/pkg/analyzer/test/generated/parser_test.dart#newcode10768 pkg/analyzer/test/generated/parser_test.dart:10768: void test_parseFunctionBody_skip_block() { These were moved so that they ...

3 years, 3 months ago (2017-08-30 21:11:54 UTC) #2

Brian Wilkerson

3 years, 3 months ago (2017-08-31 13:34:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
6c67db11cf0a006de9067020534171cf1898284a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 3004103002: Fix more of the Fasta tests (Closed)

Description

Patch Set 1 #

Patch Set 2 : add comment #

Messages