Issue 3004093002: Don't include BuiltinTypeBuilder(s) into additional exports.

Issue 3004093002: Don't include BuiltinTypeBuilder(s) into additional exports. (Closed)

Created:
3 years, 3 months ago by scheglov

Modified:
3 years, 3 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang), Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Don't include BuiltinTypeBuilder(s) into additional exports. Their `target` fails. R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e28aac09c4d74744a6e7dea0c046f6a37c7c24fe

Patch Set 1 #

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pkg/front_end/lib/src/fasta/source/source_library_builder.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

Committed patchset #1 (id:1) manually as e28aac09c4d74744a6e7dea0c046f6a37c7c24fe (presubmit successful).

3 years, 3 months ago (2017-08-30 19:49:03 UTC) #4

ahe

I'm not sure this is correct. Perhaps you could change the assert instead?

3 years, 3 months ago (2017-08-31 12:11:47 UTC) #5

scheglov

3 years, 3 months ago (2017-08-31 14:55:29 UTC) #6

Message was sent while issue was closed.

On 2017/08/31 12:11:47, ahe wrote:
> I'm not sure this is correct. Perhaps you could change the assert instead?

I don't follow.
Which assert?

Both "dynamic" and "void" are added to the core library in
LibraryBuilder.becomeCoreLibrary().
They don't implement "target", so we have to filter them out.
We need this to fix the case of re-exporting dart:core from a library.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages