Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 3004033002: [VM generic functions reification] Support generic async* and sync* functions. (Closed)

Created:
3 years, 3 months ago by regis
Modified:
3 years, 3 months ago
Reviewers:
bkonyi
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[VM generic functions reification] Support generic async* and sync* functions. R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/df70bd64ae81510455efb7fe5aa18d138426ec77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M runtime/vm/parser.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
regis
This will allow a handful of currently failing language_2 tests to pass, however, since --reify-generic-functions ...
3 years, 3 months ago (2017-08-30 00:12:26 UTC) #2
bkonyi
From what I can tell, LGTM but you might want someone else who knows the ...
3 years, 3 months ago (2017-08-30 13:35:42 UTC) #3
bkonyi
From what I can tell, LGTM but you might want someone else who knows the ...
3 years, 3 months ago (2017-08-30 13:35:43 UTC) #4
regis
On 2017/08/30 13:35:43, bkonyi wrote: > From what I can tell, LGTM but you might ...
3 years, 3 months ago (2017-08-30 16:19:22 UTC) #5
regis
3 years, 3 months ago (2017-08-30 16:19:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
df70bd64ae81510455efb7fe5aa18d138426ec77 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698