Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3003993002: Fix issues from CL 3009573002. (Closed)

Created:
3 years, 3 months ago by ahe
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update imports and expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -21 lines) Patch
M pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart View 1 chunk +5 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 2 chunks +6 lines, -1 line 0 comments Download
A pkg/front_end/test/fasta/ambiguous_export_test.dart View 1 1 chunk +41 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/ambiguous_exports.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/ambiguous_exports.dart.direct.expect View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/ambiguous_exports.dart.outline.expect View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/ambiguous_exports.dart.strong.expect View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/compile.status View 2 chunks +4 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/export_main.dart View 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/export_main.dart.direct.expect View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/export_main.dart.outline.expect View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/export_main.dart.strong.expect View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/outline.status View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/rasta/export.dart.direct.expect View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/rasta/export.dart.outline.expect View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/rasta/export.dart.strong.expect View 1 chunk +4 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/rasta/foo.dart.strong.expect View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/rasta/import_export.dart.strong.expect View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/strong.status View 1 2 chunks +4 lines, -3 lines 0 comments Download
M tests/language/language_kernel.status View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 3 months ago (2017-08-28 10:15:03 UTC) #2
Johnni Winther
lgtm
3 years, 3 months ago (2017-08-28 10:19:49 UTC) #3
ahe
3 years, 3 months ago (2017-08-28 11:52:00 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c89fb500562dd66253234b0a37544f136a42f5eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698