tests/language_2/hidden_import_test.dart - Issue 3003933002: Migrate block 116.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/language_2/hidden_import_test.dart

Issue 3003933002: Migrate block 116. (Closed)

Patch Set: Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 // Tests that dart: imports are implicitly hidden and cause warning on use.	5 // Tests that dart: imports are implicitly hidden and cause warning on use.

6	6

7 library hidden_import;	7 library hidden_import;

8	8

9 import 'hidden_import_lib.dart';	9 import 'hidden_import_lib.dart';

10 import 'hidden_import_lib.dart' as prefix;	10 import 'hidden_import_lib.dart' as prefix;

11 import 'dart:async';	11 import 'dart:async';

12 import 'dart:async' as prefix;	12 import 'dart:async' as prefix;

13	13

14 main() {	14 main() {

15 new Future(); //# 01: static type warning	15 new Future(); //# 01: static type warning
	Lasse Reichstein Nielsen 2017/08/29 07:43:40 Why is there type warning? I assumed that Dart 2 Why is there type warning? I assumed that Dart 2 removed all warnings. Bob Nystrom 2017/08/30 18:21:23 <shrug> There's no change in this test. I think we Show quoted text On 2017/08/29 07:43:40, Lasse Reichstein Nielsen wrote: > Why is there type warning? <shrug> There's no change in this test. I think we've warned on shadowing a dart: imported name for a long time. Show quoted text > I assumed that Dart 2 removed all warnings. It removes almost all, but it looks like there are a couple of things that remain warnings. Another example is a getter and setter with the same name whose property don't match. It's not an error because they don't need to match for soundness, but the warning is still there.
16 new prefix.Future(); //# 02: static type warning	16 new prefix.Future(); //# 02: static type warning

17 }	17 }

OLD	NEW

« no previous file with comments | « tests/language_2/hidden_import_lib.dart ('k') | tests/language_2/identical_closure2_test.dart » ('j') | tests/language_2/identical_closure2_test.dart » ('J')