Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 300393003: Mac: Fix fallback font selection for custom fonts (Closed)

Created:
6 years, 6 months ago by Kunihiko Sakamoto
Modified:
6 years, 6 months ago
Reviewers:
eae
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Mac: Fix fallback font selection for custom fonts This fixes a bug where a bullet character (U+25CF) becomes tofu when it is a fallback for a webfont and italic style. The fallback font (Helvetica) has a glyph for U+25CF, but its italic variation (Helvetica Oblique) does not. In such a case, we should use synthetic oblique. BUG=373389 TEST=fast/text/fallback-for-custom-font.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175243

Patch Set 1 : #

Patch Set 2 : NeedsRebaseline for a virtual test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/fallback-for-custom-font.html View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/platform/mac/fast/text/fallback-for-custom-font-expected.png View Binary file 0 comments Download
A LayoutTests/platform/mac/fast/text/fallback-for-custom-font-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
M Source/platform/fonts/mac/FontCacheMac.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Kunihiko Sakamoto
6 years, 6 months ago (2014-05-29 11:54:49 UTC) #1
eae
LGTM
6 years, 6 months ago (2014-05-29 20:53:33 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 6 months ago (2014-05-29 20:53:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/300393003/40001
6 years, 6 months ago (2014-05-29 20:56:00 UTC) #4
Kunihiko Sakamoto
The CQ bit was unchecked by ksakamoto@chromium.org
6 years, 6 months ago (2014-05-30 03:34:55 UTC) #5
Kunihiko Sakamoto
The CQ bit was checked by ksakamoto@chromium.org
6 years, 6 months ago (2014-05-30 03:39:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/300393003/60001
6 years, 6 months ago (2014-05-30 03:41:57 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-30 10:17:17 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 11:02:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9582)
6 years, 6 months ago (2014-05-30 11:02:33 UTC) #10
Kunihiko Sakamoto
The CQ bit was checked by ksakamoto@chromium.org
6 years, 6 months ago (2014-06-02 01:09:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/300393003/60001
6 years, 6 months ago (2014-06-02 01:09:50 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 01:42:58 UTC) #13
Message was sent while issue was closed.
Change committed as 175243

Powered by Google App Engine
This is Rietveld 408576698