Expose getInterfaceMembers method through ClassHierarchy.

Expose getInterfaceMembers method through ClassHierarchy.

The front end will need to use this method to iterate through the
interface of a class in order to determine when to create forwarding
stubs.

The functionality already exists; this CL merely exposes it and adds
tests.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/41dcc04a80b1c8c74c9bd08a92915bd239a89dd0

[Paul Berry, 2017-08-25 20:05:33]

paulberry@google.com changed reviewers:
+ kmillikin@google.com, scheglov@google.com

[Paul Berry, 2017-08-25 20:05:34]

I only need a review from one of you.

[scheglov, 2017-08-25 20:15:21]

LGTM

https://codereview.chromium.org/3003913002/diff/1/pkg/kernel/test/class_hiera...
File pkg/kernel/test/class_hierarchy_test.dart (right):

https://codereview.chromium.org/3003913002/diff/1/pkg/kernel/test/class_hiera...
pkg/kernel/test/class_hierarchy_test.dart:1028: unorderedEquals([
We could extract the lists of super getters/setters and reuse for both B and C.
So, we wouldn't need to search for (not existing) differences in them.

https://codereview.chromium.org/3003913002/diff/1/pkg/kernel/test/class_hiera...
pkg/kernel/test/class_hierarchy_test.dart:1052: void
test_getInterfaceMembers_mixed_in() {
Do you expect that mixing-in and extends/implements will diverge, so don't want
to put it into the previous test?

https://codereview.chromium.org/3003913002/diff/1/pkg/kernel/test/class_hiera...
pkg/kernel/test/class_hierarchy_test.dart:1221: unorderedEquals([setter_b,
nonFinalField_b]));
Maybe add one non-shadowed method from A?
There is a tiny chance that the implementation replaces the denoted interface
with the class members ignoring superinterfaces. Not that we are doing this ;-)

[Paul Berry, 2017-08-25 20:56:40]

https://codereview.chromium.org/3003913002/diff/1/pkg/kernel/test/class_hiera...
File pkg/kernel/test/class_hierarchy_test.dart (right):

https://codereview.chromium.org/3003913002/diff/1/pkg/kernel/test/class_hiera...
pkg/kernel/test/class_hierarchy_test.dart:1028: unorderedEquals([
On 2017/08/25 20:15:20, scheglov wrote:
> We could extract the lists of super getters/setters and reuse for both B and
C.
> So, we wouldn't need to search for (not existing) differences in them.

Done.

https://codereview.chromium.org/3003913002/diff/1/pkg/kernel/test/class_hiera...
pkg/kernel/test/class_hierarchy_test.dart:1052: void
test_getInterfaceMembers_mixed_in() {
On 2017/08/25 20:15:20, scheglov wrote:
> Do you expect that mixing-in and extends/implements will diverge, so don't
want
> to put it into the previous test?

Good point.  I've merged it into the previous test.

https://codereview.chromium.org/3003913002/diff/1/pkg/kernel/test/class_hiera...
pkg/kernel/test/class_hierarchy_test.dart:1221: unorderedEquals([setter_b,
nonFinalField_b]));
On 2017/08/25 20:15:20, scheglov wrote:
> Maybe add one non-shadowed method from A?
> There is a tiny chance that the implementation replaces the denoted interface
> with the class members ignoring superinterfaces. Not that we are doing this
;-)

Done.

[Paul Berry, 2017-08-25 20:57:06]

Description was changed from

==========
Expose getInterfaceMembers method through ClassHierarchy.

The front end will need to use this method to iterate through the
interface of a class in order to determine when to create forwarding
stubs.

The functionality already exists; this CL merely exposes it and adds
tests.
==========

to

==========
Expose getInterfaceMembers method through ClassHierarchy.

The front end will need to use this method to iterate through the
interface of a class in order to determine when to create forwarding
stubs.

The functionality already exists; this CL merely exposes it and adds
tests.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/41dcc04a80b1c8c74c9bd08a92915bd239a89dd0
==========

[Paul Berry, 2017-08-25 20:57:07]

Committed patchset #2 (id:20001) manually as
41dcc04a80b1c8c74c9bd08a92915bd239a89dd0 (presubmit successful).