Issue 3003863002: [kernel] Position on switch expression

Issue 3003863002: [kernel] Position on switch expression (Closed)

Created:
3 years, 3 months ago by jensj

Modified:
3 years, 3 months ago

Reviewers:
Johnni Winther, ahe

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

[kernel] Position on switch expression BUG= R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/2ba6cce3873a90603600047bc441d5f21610a597

Patch Set 2 : ... #

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -12 lines)			Patch
M	pkg/front_end/lib/src/fasta/kernel/body_builder.dart	View	1	2 chunks	+15 lines, -11 lines	0 comments	Download
M	pkg/kernel/binary.md	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/kernel/lib/binary/ast_from_binary.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	pkg/kernel/lib/binary/ast_to_binary.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/kernel_binary_flowgraph.cc	View		3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ahe

https://codereview.chromium.org/3003863002/diff/1/pkg/front_end/lib/src/fasta/parser/parser.dart File pkg/front_end/lib/src/fasta/parser/parser.dart (right): https://codereview.chromium.org/3003863002/diff/1/pkg/front_end/lib/src/fasta/parser/parser.dart#newcode3894 pkg/front_end/lib/src/fasta/parser/parser.dart:3894: Token parseSwitchBlock(Token token, Token switchKeyword) { This token is ...

3 years, 3 months ago (2017-08-25 10:04:31 UTC) #3

jensj

3 years, 3 months ago (2017-08-25 11:54:47 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2ba6cce3873a90603600047bc441d5f21610a597 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages