Issue 300383002: Start work on adding content/browser to GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 300383002: Start work on adding content/browser to GN build. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Start work on adding content/browser to GN build. This is not yet hooked up. Adds power_gadget build file. Removes blink headers stub config now that the real target exists. TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273594

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+399 lines, -26 lines)			Patch
M	content/BUILD.gn	View	1 chunk	+0 lines, -9 lines	0 comments	Download
A	content/browser/BUILD.gn	View	1 chunk	+379 lines, -0 lines	0 comments	Download
A +	content/browser/browser.gni	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	content/common/BUILD.gn	View	2 chunks	+3 lines, -4 lines	0 comments	Download
A +	content/public/browser/BUILD.gn	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	content/public/common/BUILD.gn	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	content/public/renderer/BUILD.gn	View	2 chunks	+1 line, -1 line	0 comments	Download
M	content/renderer/BUILD.gn	View	2 chunks	+1 line, -1 line	0 comments	Download
A +	third_party/power_gadget/BUILD.gn	View	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

6 years, 6 months ago (2014-05-29 21:08:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r273594 (presubmit successful).

Expand Messages | Collapse Messages