Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: runtime/vm/il_printer.cc

Issue 3003793002: [vm,aot] Improve performance of certain 'is' operations (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/il_printer.cc
diff --git a/runtime/vm/il_printer.cc b/runtime/vm/il_printer.cc
index b09198cf2bb1664ca0f627db01c70420f24f8d90..d9b1f7fd90119ca6dc6fbd22fdb51c0b7cdf9b5f 100644
--- a/runtime/vm/il_printer.cc
+++ b/runtime/vm/il_printer.cc
@@ -166,8 +166,7 @@ void CompileType::PrintTo(BufferFormatter* f) const {
const Class& cls =
Class::Handle(Isolate::Current()->class_table()->At(cid_));
type_name = String::Handle(cls.ScrubbedName()).ToCString();
- } else if (type_ != NULL &&
- !type_->Equals(Type::Handle(Type::DynamicType()))) {
+ } else if (type_ != NULL && !type_->IsDynamicType()) {
type_name = type_->ToCString();
} else if (!is_nullable()) {
type_name = "!null";
@@ -368,7 +367,8 @@ void Definition::PrintTo(BufferFormatter* f) const {
}
if (type_ != NULL &&
- ((type_->ToNullableCid() != kDynamicCid) || !type_->is_nullable())) {
+ ((type_->ToNullableCid() != kDynamicCid) ||
+ !type_->ToAbstractType()->IsDynamicType() || !type_->is_nullable())) {
f->Print(" ");
type_->PrintTo(f);
}
« runtime/vm/flow_graph_type_propagator.cc ('K') | « runtime/vm/flow_graph_type_propagator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698