Clear StringToken.canonicalizer after each parsing.

Clear StringToken.canonicalizer after each parsing.

Otherwise the canonicalizer grows without limit, and if the user
edits files, we constantly parse new strings, so constantly add new
entries into the cananonicalizer. Basically, it is not friendly for
long running processes. I'm not quite sure why we need to makes it
static anyway, if it can be used only for the same file content. Once
we're done with a file, that is it, we don't need its entries.

Anyway, this fixes a leak in Analysis Server.

R=ahe@google.com, brianwilkerson@google.com, danrubel@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/dab5318fad8e8537300371307bc30a536edef67c

[Brian Wilkerson, 2017-08-23 16:47:48]

lgtm

[danrubel, 2017-08-23 17:44:33]

LGTM

[scheglov, 2017-08-23 17:57:32]

Description was changed from

==========
Clear StringToken.canonicalizer after each parsing.

Otherwise the canonicalizer grows without limit, and if the user
edits files, we constantly parse new strings, so constantly add new
entries into the cananonicalizer. Basically, it is not friendly for
long running processes. I'm not quite sure why we need to makes it
static anyway, if it can be used only for the same file content. Once
we're done with a file, that is it, we don't need its entries.

Anyway, this fixes a leak in Analysis Server.

R=brianwilkerson@google.com, paulberry@google.com, danrubel@google.com,
ahe@google.com
BUG=
==========

to

==========
Clear StringToken.canonicalizer after each parsing.

Otherwise the canonicalizer grows without limit, and if the user
edits files, we constantly parse new strings, so constantly add new
entries into the cananonicalizer. Basically, it is not friendly for
long running processes. I'm not quite sure why we need to makes it
static anyway, if it can be used only for the same file content. Once
we're done with a file, that is it, we don't need its entries.

Anyway, this fixes a leak in Analysis Server.

R=ahe@google.com, brianwilkerson@google.com, danrubel@google.com,
paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/dab5318fad8e8537300371307bc30a536edef67c
==========

[scheglov, 2017-08-23 17:57:33]

Committed patchset #1 (id:1) manually as
dab5318fad8e8537300371307bc30a536edef67c (presubmit successful).

[ahe, 2017-08-24 09:37:42]

I'm not sure why we need string canonicalization at all. Is this turned on in
Fasta?