Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: pkg/front_end/test/kernel_generator_test.dart

Issue 3003743002: Move tools to tool folder. (Closed)
Patch Set: Fix two problems that show up elsewhere. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/test/kernel_generator_test.dart
diff --git a/pkg/front_end/test/kernel_generator_test.dart b/pkg/front_end/test/kernel_generator_test.dart
index cbed95ef8e44f39cd7d89ee567c3d4c493c4f9e2..d6c9a0b2a2697a31e382224029e951b1c11465f8 100644
--- a/pkg/front_end/test/kernel_generator_test.dart
+++ b/pkg/front_end/test/kernel_generator_test.dart
@@ -63,6 +63,10 @@ main() {
expect(errors.first.message, messageMissingMain.message);
});
+ // TODO(ahe): This test is wrong at least with respect to expecting that
+ // [deprecated_InputError] leaks through the API. Furthermore, the default
+ // behavior should be to recover from errors, as this is the most important
+ // use case we have.
test('default error handler throws on errors', () async {
var options = new CompilerOptions();
var exceptionThrown = false;
@@ -73,7 +77,7 @@ main() {
expect('${e.error}', contains("Compilation aborted"));
}
expect(exceptionThrown, isTrue);
- });
+ }, skip: true /* Issue 30194 */);
test('generated program contains source-info', () async {
var program = await compileScript('a() => print("hi"); main() {}',

Powered by Google App Engine
This is Rietveld 408576698