Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: pkg/front_end/lib/compiler_options.dart

Issue 3003743002: Move tools to tool folder. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/compiler_options.dart
diff --git a/pkg/front_end/lib/compiler_options.dart b/pkg/front_end/lib/compiler_options.dart
index 298b45659f72d4c0bafa384225d4dacc1a916f9a..04f516eb3237ed06ef3891e3232b995b4a2815d9 100644
--- a/pkg/front_end/lib/compiler_options.dart
+++ b/pkg/front_end/lib/compiler_options.dart
@@ -217,8 +217,7 @@ class CompilerOptions {
/// Whether the compiler should throw as soon as it encounters a
/// compilation error.
- // TODO(sigmund): change the default (issue #30194).
- bool throwOnErrors = true;
+ bool throwOnErrors = false;
ahe 2017/08/23 15:07:18 This causes all tools to exit with an unhandled ex
Siggi Cherem (dart-lang) 2017/08/23 20:17:34 I commented on issue #30194, I think we should in
ahe 2017/08/24 11:52:01 I'd rather go ahead with this and let the resoluti
/// Whether the compiler should throw as soon as it encounters a
/// compilation warning.
« no previous file with comments | « no previous file | pkg/front_end/lib/src/base/processed_options.dart » ('j') | pkg/front_end/lib/src/base/processed_options.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698