Move tools to tool folder.

pkg/front_end/test/kernel_generator_test.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:front_end/front_end.dart';
 import 'package:front_end/src/fasta/fasta_codes.dart';
 import 'package:front_end/src/fasta/kernel/utils.dart';
 import 'package:front_end/src/fasta/deprecated_problems.dart'
     show deprecated_InputError;
 import 'package:front_end/src/testing/compiler_common.dart';
@@ skipping 45 matching lines @@
       expect(printMember.function.body is EmptyStatement, isTrue);
     });
 
     test('compiler requires a main method', () async {
       var errors = [];
       var options = new CompilerOptions()..onError = (e) => errors.add(e);
       await compileScript('a() => print("hi");', options: options);
       expect(errors.first.message, messageMissingMain.message);
     });
 
-    test('default error handler throws on errors', () async {
-      var options = new CompilerOptions();
-      var exceptionThrown = false;
-      try {
-        await compileScript('a() => print("hi");', options: options);
-      } on deprecated_InputError catch (e) {
-        exceptionThrown = true;
-        expect('${e.error}', contains("Compilation aborted"));
-      }
-      expect(exceptionThrown, isTrue);
-    });
+    // TODO(ahe): This test is wrong at least with respect to expecting that
+    // [deprecated_InputError] leaks through the API. Furthermore, the default
+    // behavior should be to recover from errors, as this is the most important
+    // use case we have.

[ahe, 2017/08/23 15:07:18]

Please let me know if I can delete this test?

If you want to preserve it, please implement this behavior by way of a default
ErrorHandler that doesn't throw deprecated_InputError.

[Siggi Cherem (dart-lang), 2017/08/23 20:17:35]

I'd like to keep something to test a default-error behavior. I agree we don't
need to leak deprecated_InputError, I just want to make sure we have good
defaults for the public API. Rather than disabling it, I'd prefer to keep the
current broken behavior in the public APIs until we fix #30194 (and fix the
issue on the command-line-tools).

[ahe, 2017/08/24 11:52:02]

I'd rather wait until you have time to implement throwOnErrors correctly.

+    // ignore: DEAD_CODE
+    if (false) {

[Siggi Cherem (dart-lang), 2017/08/23 20:17:35]

Might not be relevant depending on how we address things above, but instead of
if (false) {...}, you can pass `skip: true` at the end of the test declaration:

test('...', () {
   ...
  }, skip: true /* Issue XYZ */);

[ahe, 2017/08/24 11:52:02]

Done.

+      test('default error handler throws on errors', () async {
+        var options = new CompilerOptions();
+        var exceptionThrown = false;
+        try {
+          await compileScript('a() => print("hi");', options: options);
+        } on deprecated_InputError catch (e) {
+          exceptionThrown = true;
+          expect('${e.error}', contains("Compilation aborted"));
+        }
+        expect(exceptionThrown, isTrue);
+      });
+    }
 
     test('generated program contains source-info', () async {
       var program = await compileScript('a() => print("hi"); main() {}',
           fileName: 'a.dart');
       // Kernel always store an empty '' key in the map, so there is always at
       // least one. Having more means that source-info is added.
       expect(program.uriToSource.keys.length, greaterThan(1));
       expect(program.uriToSource['file:///a/b/c/a.dart'], isNotNull);
     });
 
@@ skipping 119 matching lines @@
       checkDCallsC(unitD1);
 
       var unitD2 = await compileUnit(['d.dart'], sources,
           inputSummaries: ['bc.dill', 'a.dill']);
       checkDCallsC(unitD2);
     });
 
     // TODO(sigmund): add tests with trimming dependencies
   });
 }