Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: pkg/analysis_server/lib/src/plugin/plugin_manager.dart

Issue 3003663002: Remove the auto-discovery of plugins (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/plugin/plugin_watcher.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/plugin/plugin_manager.dart
diff --git a/pkg/analysis_server/lib/src/plugin/plugin_manager.dart b/pkg/analysis_server/lib/src/plugin/plugin_manager.dart
index 6d1edf8fe4c64313f0b7d368f4168b0de5753802..2f21bc4f41db0308076d3220c52e816f831918e7 100644
--- a/pkg/analysis_server/lib/src/plugin/plugin_manager.dart
+++ b/pkg/analysis_server/lib/src/plugin/plugin_manager.dart
@@ -291,11 +291,6 @@ class PluginManager {
final InstrumentationService instrumentationService;
/**
- * The list of globs used to match plugin paths that have been whitelisted.
- */
- List<Glob> _whitelistGlobs;
-
- /**
* A table mapping the paths of plugins to information about those plugins.
*/
Map<String, PluginInfo> _pluginMap = <String, PluginInfo>{};
@@ -326,15 +321,7 @@ class PluginManager {
* running plugins will be handled by the given [notificationManager].
*/
PluginManager(this.resourceProvider, this.byteStorePath, this.sdkPath,
- this.notificationManager, this.instrumentationService) {
- // TODO(brianwilkerson) Figure out the right list of plugin paths.
- _whitelistGlobs = <Glob>[
- new Glob(resourceProvider.pathContext.separator,
- '**/angular_analyzer_plugin/tools/analyzer_plugin'),
- new Glob(resourceProvider.pathContext.separator,
- '**angular/tools/analyzer_plugin')
- ];
- }
+ this.notificationManager, this.instrumentationService);
/**
* Return a list of all of the plugins that are currently known.
@@ -349,9 +336,6 @@ class PluginManager {
*/
Future<Null> addPluginToContextRoot(
analyzer.ContextRoot contextRoot, String path) async {
- if (!_isWhitelisted(path)) {
- return;
- }
PluginInfo plugin = _pluginMap[path];
bool isNew = plugin == null;
if (isNew) {
@@ -613,16 +597,6 @@ class PluginManager {
}
/**
- * Whitelist all plugins.
- */
- @visibleForTesting
- void whitelistEverything() {
- _whitelistGlobs = <Glob>[
- new Glob(resourceProvider.pathContext.separator, '**/*')
- ];
- }
-
- /**
* Compute the paths to be returned by the enclosing method given that the
* plugin should exist in the given [pluginFolder].
*/
@@ -741,18 +715,6 @@ class PluginManager {
}
/**
- * Return `true` if the plugin with the given [path] has been whitelisted.
- */
- bool _isWhitelisted(String path) {
- for (Glob glob in _whitelistGlobs) {
- if (glob.matches(path)) {
- return true;
- }
- }
- return false;
- }
-
- /**
* Return the names of packages that are listed as dependencies in the given
* [pubspecFile].
*/
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/plugin/plugin_watcher.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698