Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 3003663002: Remove the auto-discovery of plugins (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, mfairhurst
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -128 lines) Patch
M pkg/analysis_server/lib/src/plugin/plugin_manager.dart View 5 chunks +1 line, -39 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/plugin_watcher.dart View 3 chunks +15 lines, -83 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/plugin_manager_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Additional clean-up in a separate CL.
3 years, 4 months ago (2017-08-22 15:39:29 UTC) #2
scheglov
LGTM
3 years, 4 months ago (2017-08-22 15:42:34 UTC) #3
Brian Wilkerson
3 years, 4 months ago (2017-08-22 16:04:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4aeedec64e8522eff641d5c98f96ae89d4aa7f8e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698