Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2132)

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 3003593002: [vm] Cleanup Instruction::Effects(), prepare to cleanup Dependencies() (Closed)
Patch Set: Address review comment Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_type_propagator.cc
diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc
index dbadcf349a2b12de2d213396d95820089d353fa2..8b8e9618a3a43af14d77388ea858df2630a7d99c 100644
--- a/runtime/vm/flow_graph_type_propagator.cc
+++ b/runtime/vm/flow_graph_type_propagator.cc
@@ -217,22 +217,10 @@ void FlowGraphTypePropagator::VisitCheckClass(CheckClassInstr* check) {
return;
}
- if (!check->Dependencies().IsNone()) {
- // TODO(vegorov): If check is affected by side-effect we can still propagate
- // the type further but not the cid.
- return;
- }
-
SetCid(check->value()->definition(), check->cids().MonomorphicReceiverCid());
}
void FlowGraphTypePropagator::VisitCheckClassId(CheckClassIdInstr* check) {
- if (!check->Dependencies().IsNone()) {
- // TODO(vegorov): If check is affected by side-effect we can still propagate
- // the type further but not the cid.
- return;
- }
-
LoadClassIdInstr* load_cid =
check->value()->definition()->OriginalDefinition()->AsLoadClassId();
if (load_cid != NULL && check->cids().IsSingleCid()) {
« no previous file with comments | « runtime/vm/flow_graph.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698