runtime/vm/constant_propagator.cc - Issue 3003593002: [vm] Cleanup Instruction::Effects(), prepare to cleanup Dependencies()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/constant_propagator.cc

Issue 3003593002: [vm] Cleanup Instruction::Effects(), prepare to cleanup Dependencies() (Closed)

Patch Set: Address review comment Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/constant_propagator.cc

diff --git a/runtime/vm/constant_propagator.cc b/runtime/vm/constant_propagator.cc

index 75b41ca2069c7137c3f8c0f827b2c6c669f42fdb..b5b26463444c8d87702c3a7e01c54d620d29ac16 100644

--- a/runtime/vm/constant_propagator.cc

+++ b/runtime/vm/constant_propagator.cc

@@ -1378,7 +1378,7 @@ void ConstantPropagator::EliminateRedundantBranches() {

BlockEntryInstr* block = b.Current();

BranchInstr* branch = block->last_instruction()->AsBranch();

empty_blocks->Clear();

- if ((branch != NULL) && branch->Effects().IsNone()) {

+ if ((branch != NULL) && !branch->HasUnknownSideEffects()) {

ASSERT(branch->previous() != NULL); // Not already eliminated.

BlockEntryInstr* if_true =

FindFirstNonEmptySuccessor(branch->true_successor(), empty_blocks);

« no previous file with comments | « no previous file | runtime/vm/flow_graph.cc » ('j') | no next file with comments »