[vm] Cleanup Instruction::Effects(), prepare to cleanup Dependencies()

runtime/vm/constant_propagator.cc

Index: runtime/vm/constant_propagator.cc
diff --git a/runtime/vm/constant_propagator.cc b/runtime/vm/constant_propagator.cc
index 75b41ca2069c7137c3f8c0f827b2c6c669f42fdb..c62dd29f7e280f6d5a8880377bed5db9c4ff7505 100644
--- a/runtime/vm/constant_propagator.cc
+++ b/runtime/vm/constant_propagator.cc
@@ -1378,7 +1378,7 @@ void ConstantPropagator::EliminateRedundantBranches() {
     BlockEntryInstr* block = b.Current();
     BranchInstr* branch = block->last_instruction()->AsBranch();
     empty_blocks->Clear();
-    if ((branch != NULL) && branch->Effects().IsNone()) {
+    if ((branch != NULL) && !branch->HasSideEffects()) {
       ASSERT(branch->previous() != NULL);  // Not already eliminated.
       BlockEntryInstr* if_true =
           FindFirstNonEmptySuccessor(branch->true_successor(), empty_blocks);