Add commit queue settings to Dart

Add commit queue settings to Dart

These will be used on Gerrit reviews, to trigger try bots and the
commit queue.  The commit queue is currently set up to commit to
GitHub. This will be changed when the mirroring direction changes.

BUG=737149
R=athom@google.com

Committed: https://github.com/dart-lang/sdk/commit/2149487c0ddecb4661b42ec25ed6ee12ea994c32

[Bill Hesse, 2017-08-21 12:49:56]

whesse@google.com changed reviewers:
+ athom@google.com

[Alexander Thomas, 2017-08-21 13:05:15]

lgtm

[Bill Hesse, 2017-08-21 13:36:18]

Description was changed from

==========
Add commit queue settings to Dart

These will be used on Gerrit reviews, to trigger try bots and the
commit queue.  The commit queue is currently set up to commit to
GitHub. This will be changed when the mirroring direction changes.

BUG=737149
==========

to

==========
Add commit queue settings to Dart

These will be used on Gerrit reviews, to trigger try bots and the
commit queue.  The commit queue is currently set up to commit to
GitHub. This will be changed when the mirroring direction changes.

BUG=737149
R=athom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2149487c0ddecb4661b42ec25ed6ee12ea994c32
==========

[Bill Hesse, 2017-08-21 13:36:19]

Committed patchset #4 (id:60001) manually as
2149487c0ddecb4661b42ec25ed6ee12ea994c32 (presubmit successful).

[tandrii(chromium), 2017-08-21 15:24:05]

tandrii@chromium.org changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2017-08-21 15:24:06]

https://codereview.chromium.org/3003523002/diff/60001/tools/infra/config/cq.cfg
File tools/infra/config/cq.cfg (right):

https://codereview.chromium.org/3003523002/diff/60001/tools/infra/config/cq.c...
tools/infra/config/cq.cfg:6: git_repo_url:
"https://github.com/dart-lang/sdk.git"
this won't work. This is gerrit CQ, not a Rietveld one, and Gerrit CQ needs a
Gerrit host here.

[Bill Hesse, 2017-08-21 15:26:40]

https://codereview.chromium.org/3003523002/diff/60001/tools/infra/config/cq.cfg
File tools/infra/config/cq.cfg (right):

https://codereview.chromium.org/3003523002/diff/60001/tools/infra/config/cq.c...
tools/infra/config/cq.cfg:6: git_repo_url:
"https://github.com/dart-lang/sdk.git"
On 2017/08/21 15:24:06, tandrii(chromium) wrote:
> this won't work. This is gerrit CQ, not a Rietveld one, and Gerrit CQ needs a
> Gerrit host here.

OK, I saw in an earlier post on the gob->github sync issue, and in the
go/we-need-cq, that groups were managing to make cq commit to github from their
gerrit reviews.  Is there no way to make Gerrit commit to Github?

[tandrii(chromium), 2017-08-21 15:33:57]

On 2017/08/21 15:26:40, Bill Hesse wrote:
>
https://codereview.chromium.org/3003523002/diff/60001/tools/infra/config/cq.cfg
> File tools/infra/config/cq.cfg (right):
> 
>
https://codereview.chromium.org/3003523002/diff/60001/tools/infra/config/cq.c...
> tools/infra/config/cq.cfg:6: git_repo_url:
> "https://github.com/dart-lang/sdk.git"
> On 2017/08/21 15:24:06, tandrii(chromium) wrote:
> > this won't work. This is gerrit CQ, not a Rietveld one, and Gerrit CQ needs
a
> > Gerrit host here.
> 
> OK, I saw in an earlier post on the gob->github sync issue, and in the
> go/we-need-cq, that groups were managing to make cq commit to github from
their
> gerrit reviews.  Is there no way to make Gerrit commit to Github?

There might be, but i'm not aware of one. In any case, Gerrit CQ will use Gerrit
Submit API to piggy-back on Gerrit security.
Rietveld CQ did "git push" and thus could work with almost any git host offered
under https://.