Issue 3003433002: [infra] Remove dependency on gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3003433002: [infra] Remove dependency on gyp (Closed)

Created:
3 years, 4 months ago by zra

Modified:
3 years, 4 months ago

Reviewers:
Bill Hesse, rmacnak

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -47 lines)			Patch
M	DEPS	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	build/vs_toolchain.py	View		2 chunks	+1 line, -13 lines	0 comments	Download
D	runtime/tools/generate_projects.py	View	1	1 chunk	+0 lines, -29 lines	0 comments	Download

Total messages: 7 (2 generated)

rmacnak

LGTM One lingering reference: git grep "import gyp" runtime/tools/generate_projects.py: import gyp

3 years, 4 months ago (2017-08-18 00:29:35 UTC) #3

zra

On 2017/08/18 00:29:35, rmacnak wrote: > LGTM > > One lingering reference: > > git ...

3 years, 4 months ago (2017-08-18 15:51:19 UTC) #5

zra

3 years, 4 months ago (2017-08-18 15:51:46 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
783f1e8c04c861118370d9238a0c4040e8a64e5f (presubmit successful).