Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: runtime/vm/service.cc

Issue 3003383002: [VM] Make us compile with debug-optimization-level=0 again (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/isolate.h ('K') | « runtime/vm/isolate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index fe24ad50bccec872c066d1292279f343b1873a33..7a65b64b08166de047c61fd25d457a7ac8f064f6 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -2559,6 +2559,7 @@ static const MethodParameter* reload_sources_params[] = {
};
static bool ReloadSources(Thread* thread, JSONStream* js) {
+#if !defined(PRODUCT) && !defined(DART_PRECOMPILED_RUNTIME)
Vyacheslav Egorov (Google) 2017/08/25 11:43:41 we are already in the !defined(PRODUCT) code (note
kustermann 2017/08/25 11:46:17 Done.
Isolate* isolate = thread->isolate();
if (!isolate->compilation_allowed()) {
js->PrintError(kFeatureDisabled,
@@ -2596,6 +2597,11 @@ static bool ReloadSources(Thread* thread, JSONStream* js) {
Service::CheckForPause(isolate, js);
return true;
+#else // !defined(PRODUCT) && !defined(DART_PRECOMPILED_RUNTIME)
+ js->PrintError(kFeatureDisabled,
+ "This isolate cannot reload sources right now.");
+ return true;
+#endif // !defined(PRODUCT) && !defined(DART_PRECOMPILED_RUNTIME)
}
void Service::CheckForPause(Isolate* isolate, JSONStream* stream) {
« runtime/vm/isolate.h ('K') | « runtime/vm/isolate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698