[VM] Make us compile with debug-optimization-level=0 again

[VM] Make us compile with debug-optimization-level=0 again

After [0] landed our debug builders managed to still compile, because
the default debug-optimization-level allows the compiler to inline. This
caused a "CanReload() const { return false; }" to be inlined and
constant folded, so the call to ReloadSources() was eliminated.

Compiling with debug-optimization-level=0 disables inlining and keeps
the call, which gives us a linker error when building the
dart_precompiled_runtime target.

[0] https://codereview.chromium.org/2997243002

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/76a00500ad139af15d05da916cfe689bcd7b2ad6

[kustermann, 2017-08-25 11:35:26]

kustermann@google.com changed reviewers:
+ kmilka@google.com, vegorov@google.com

[Vyacheslav Egorov (Google), 2017-08-25 11:43:41]

lgtm with comments addressed

https://codereview.chromium.org/3003383002/diff/1/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/3003383002/diff/1/runtime/vm/isolate.h#newcod...
runtime/vm/isolate.h:511: #if !defined(PRODUCT) &&
!defined(DART_PRECOMPILED_RUNTIME)
?

https://codereview.chromium.org/3003383002/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/3003383002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2562: #if !defined(PRODUCT) &&
!defined(DART_PRECOMPILED_RUNTIME)
we are already in the !defined(PRODUCT) code (note JSONStream is not available
in PRODUCT)

[kustermann, 2017-08-25 11:45:13]

Patchset #2 (id:20001) has been deleted

[kustermann, 2017-08-25 11:46:17]

https://codereview.chromium.org/3003383002/diff/1/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/3003383002/diff/1/runtime/vm/isolate.h#newcod...
runtime/vm/isolate.h:511: #if !defined(PRODUCT) &&
!defined(DART_PRECOMPILED_RUNTIME)
On 2017/08/25 11:43:41, Vyacheslav Egorov (Google) wrote:
> ?

Done.

https://codereview.chromium.org/3003383002/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/3003383002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:2562: #if !defined(PRODUCT) &&
!defined(DART_PRECOMPILED_RUNTIME)
On 2017/08/25 11:43:41, Vyacheslav Egorov (Google) wrote:
> we are already in the !defined(PRODUCT) code (note JSONStream is not available
> in PRODUCT)

Done.

[kustermann, 2017-08-25 11:46:31]

Description was changed from

==========
[VM] Make us compile with debug-optimization-level=0 again

After [0] landed our debug builders managed to still compile, because
the default debug-optimization-level allows the compiler to inline. This
caused a "CanReload() const { return false; }" to be inlined and
constant folded, so the call to ReloadSources() was eliminated.

Compiling with debug-optimization-level=0 disables inlining and keeps
the call, which gives us a linker error when building the
dart_precompiled_runtime target.

[0] https://codereview.chromium.org/2997243002
==========

to

==========
[VM] Make us compile with debug-optimization-level=0 again

After [0] landed our debug builders managed to still compile, because
the default debug-optimization-level allows the compiler to inline. This
caused a "CanReload() const { return false; }" to be inlined and
constant folded, so the call to ReloadSources() was eliminated.

Compiling with debug-optimization-level=0 disables inlining and keeps
the call, which gives us a linker error when building the
dart_precompiled_runtime target.

[0] https://codereview.chromium.org/2997243002

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/76a00500ad139af15d05da916cfe689bcd7b2ad6
==========

[kustermann, 2017-08-25 11:46:32]

Committed patchset #2 (id:40001) manually as
76a00500ad139af15d05da916cfe689bcd7b2ad6 (presubmit successful).

[kmilka, 2017-08-25 17:11:32]

On 2017/08/25 11:46:32, kustermann wrote:
> Committed patchset #2 (id:40001) manually as
> 76a00500ad139af15d05da916cfe689bcd7b2ad6 (presubmit successful).

I'm going to guess you meant to include kmillikin@ rather than me?