Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 3003363002: Report compile time errors when assert initializers fail. (Closed)

Created:
3 years, 3 months ago by scheglov
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -2 lines) Patch
M pkg/analyzer/lib/error/error.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/constant/evaluation.dart View 1 chunk +18 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 1 chunk +30 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 3 months ago (2017-08-24 21:39:03 UTC) #1
Brian Wilkerson
lgtm
3 years, 3 months ago (2017-08-24 21:42:36 UTC) #2
scheglov
3 years, 3 months ago (2017-08-24 21:48:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
556b0284b316ffc584bd05dc509a193c7c76e329 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698