Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: pkg/analyzer_cli/test/options_test.dart

Issue 3003343002: fix two test failures in analyzer_cli/test/options_test.dart (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_cli/test/options_test.dart
diff --git a/pkg/analyzer_cli/test/options_test.dart b/pkg/analyzer_cli/test/options_test.dart
index aa40368a4ecfd94cd8404884489fd63f82bb5f5e..63e0d9903515d635c3c933099194872add81473c 100644
--- a/pkg/analyzer_cli/test/options_test.dart
+++ b/pkg/analyzer_cli/test/options_test.dart
@@ -8,9 +8,10 @@ import 'dart:io';
import 'package:analyzer_cli/src/driver.dart';
import 'package:analyzer_cli/src/options.dart';
+import 'package:telemetry/telemetry.dart' as telemetry;
import 'package:test/test.dart';
-import 'package:usage/usage.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';
+import 'package:usage/usage.dart';
main() {
group('CommandLineOptions', () {
@@ -234,23 +235,27 @@ main() {
expect(failureMessage, equals('Invalid Dart SDK path: &&&&&'));
});
- test('--analytics', () {
- AnalyticsMock mock = new AnalyticsMock()..enabled = false;
- setAnalytics(mock);
- CommandLineOptions.parse(['--analytics']);
- expect(mock.enabled, true);
- expect(lastExitHandlerCode, 0);
- expect(outStringBuffer.toString(), contains('Analytics are currently'));
- });
-
- test('--no-analytics', () {
- AnalyticsMock mock = new AnalyticsMock()..enabled = false;
- setAnalytics(mock);
- CommandLineOptions.parse(['--no-analytics']);
- expect(mock.enabled, false);
- expect(lastExitHandlerCode, 0);
- expect(outStringBuffer.toString(), contains('Analytics are currently'));
- });
+ if (telemetry.SHOW_ANALYTICS_UI) {
+ test('--analytics', () {
+ AnalyticsMock mock = new AnalyticsMock()..enabled = false;
+ setAnalytics(mock);
+ CommandLineOptions.parse(['--analytics']);
+ expect(mock.enabled, true);
+ expect(lastExitHandlerCode, 0);
+ expect(
+ outStringBuffer.toString(), contains('Analytics are currently'));
+ });
+
+ test('--no-analytics', () {
+ AnalyticsMock mock = new AnalyticsMock()..enabled = false;
+ setAnalytics(mock);
+ CommandLineOptions.parse(['--no-analytics']);
+ expect(mock.enabled, false);
+ expect(lastExitHandlerCode, 0);
+ expect(
+ outStringBuffer.toString(), contains('Analytics are currently'));
+ });
+ }
});
});
defineReflectiveTests(CommandLineOptionsTest);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698