Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3003343002: fix two test failures in analyzer_cli/test/options_test.dart (Closed)

Created:
3 years, 4 months ago by devoncarew
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix two test failures in analyzer_cli/test/options_test.dart BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/4c5531315b61ef7d78a4392d4494a0f57dacd805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -18 lines) Patch
M pkg/analyzer_cli/test/options_test.dart View 2 chunks +23 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
devoncarew
3 years, 4 months ago (2017-08-24 18:34:21 UTC) #2
Brian Wilkerson
lgtm
3 years, 4 months ago (2017-08-24 18:35:31 UTC) #3
devoncarew
Committed patchset #1 (id:1) manually as 4c5531315b61ef7d78a4392d4494a0f57dacd805 (presubmit successful).
3 years, 4 months ago (2017-08-24 18:36:43 UTC) #5
scheglov
3 years, 4 months ago (2017-08-24 18:40:19 UTC) #6
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698