Prepare inference test for kernel based inference

Prepare inference test for kernel based inference

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/2c3e487503970780e971c0d156dcf8fdba00194f

[Johnni Winther, 2017-08-24 11:42:54]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-08-25 00:23:46]

lgtm

https://codereview.chromium.org/3003323002/diff/1/tests/compiler/dart2js/clos...
File tests/compiler/dart2js/closure/closure_test.dart (right):

https://codereview.chromium.org/3003323002/diff/1/tests/compiler/dart2js/clos...
tests/compiler/dart2js/closure/closure_test.dart:28: //
TODO(johnnniwinther,efortuna): Enable the these tests for .dill.
the these => these

https://codereview.chromium.org/3003323002/diff/1/tests/compiler/dart2js/infe...
File tests/compiler/dart2js/inference/inference_test_helper.dart (right):

https://codereview.chromium.org/3003323002/diff/1/tests/compiler/dart2js/infe...
tests/compiler/dart2js/inference/inference_test_helper.dart:95: /// Fills
[actualMap] with the data and [sourceSpanMap] with the source spans
this was in the comment before too, but where is sourceSpanMap?

https://codereview.chromium.org/3003323002/diff/1/tests/compiler/dart2js/infe...
File tests/compiler/dart2js/inference/send_test.dart (left):

https://codereview.chromium.org/3003323002/diff/1/tests/compiler/dart2js/infe...
tests/compiler/dart2js/inference/send_test.dart:13: await for (FileSystemEntity
entity in dataDir.list()) {
we were running all tests twice?

should we then just rename "typemask_test" as "inference_test" (since it will
basically run all the inference tests?

[Johnni Winther, 2017-08-25 07:44:25]

https://codereview.chromium.org/3003323002/diff/1/tests/compiler/dart2js/clos...
File tests/compiler/dart2js/closure/closure_test.dart (right):

https://codereview.chromium.org/3003323002/diff/1/tests/compiler/dart2js/clos...
tests/compiler/dart2js/closure/closure_test.dart:28: //
TODO(johnnniwinther,efortuna): Enable the these tests for .dill.
On 2017/08/25 00:23:46, Siggi Cherem (dart-lang) wrote:
> the these => these

Done.

https://codereview.chromium.org/3003323002/diff/1/tests/compiler/dart2js/infe...
File tests/compiler/dart2js/inference/inference_test_helper.dart (right):

https://codereview.chromium.org/3003323002/diff/1/tests/compiler/dart2js/infe...
tests/compiler/dart2js/inference/inference_test_helper.dart:95: /// Fills
[actualMap] with the data and [sourceSpanMap] with the source spans
On 2017/08/25 00:23:46, Siggi Cherem (dart-lang) wrote:
> this was in the comment before too, but where is sourceSpanMap?

It was copied. Fix in both cases.

https://codereview.chromium.org/3003323002/diff/1/tests/compiler/dart2js/infe...
File tests/compiler/dart2js/inference/send_test.dart (left):

https://codereview.chromium.org/3003323002/diff/1/tests/compiler/dart2js/infe...
tests/compiler/dart2js/inference/send_test.dart:13: await for (FileSystemEntity
entity in dataDir.list()) {
On 2017/08/25 00:23:46, Siggi Cherem (dart-lang) wrote:
> we were running all tests twice?
> 
> should we then just rename "typemask_test" as "inference_test" (since it will
> basically run all the inference tests?

No. I just renamed send_test to typemask_test. Now renamed to inference_test.

[Johnni Winther, 2017-08-25 07:44:36]

Description was changed from

==========
Prepare inference test for kernel based inference
==========

to

==========
Prepare inference test for kernel based inference

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2c3e487503970780e971c0d156dcf8fdba00194f
==========

[Johnni Winther, 2017-08-25 07:44:38]

Committed patchset #2 (id:20001) manually as
2c3e487503970780e971c0d156dcf8fdba00194f (presubmit successful).