Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 3003283003: Handle missing break in last switch case (Closed)

Created:
3 years, 3 months ago by Johnni Winther
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -40 lines) Patch
M pkg/compiler/lib/src/js_model/locals.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/switch_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 12 chunks +37 lines, -37 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 3 months ago (2017-08-24 13:41:49 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 3 months ago (2017-08-25 00:30:22 UTC) #3
Johnni Winther
3 years, 3 months ago (2017-08-30 09:32:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3f0c2d4bb3e382bc140f6359f7d963809f861e2e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698