content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 300323005: Route selection bounds updates through the compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 300323005: Route selection bounds updates through the compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updates Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/layer_tree_impl.cc ('K') | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index 8499348116f1f071758b2f6f572737449e74f545..d84ff6c31d047fba30e9f32997d5c780446247bb 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -898,12 +898,14 @@ gfx::Size RenderWidgetHostViewAura::GetRequestedRendererSize() const {

void RenderWidgetHostViewAura::SelectionBoundsChanged(

const ViewHostMsg_SelectionBounds_Params& params) {

- if (selection_anchor_rect_ == params.anchor_rect &&

- selection_focus_rect_ == params.focus_rect)

+ gfx::Rect anchor_rect = gfx::ToEnclosingRect(params.anchor_rect);

+ gfx::Rect focus_rect = gfx::ToEnclosingRect(params.focus_rect);

+ if (selection_anchor_rect_ == anchor_rect &&

+ selection_focus_rect_ == focus_rect)

return;

- selection_anchor_rect_ = params.anchor_rect;

- selection_focus_rect_ = params.focus_rect;

+ selection_anchor_rect_ = anchor_rect;

+ selection_focus_rect_ = focus_rect;

if (GetInputMethod())

GetInputMethod()->OnCaretBoundsChanged(this);