Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: content/renderer/render_widget.cc

Issue 300323005: Route selection bounds updates through the compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Defer selection updates until after compositor scheduling Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 3b3c6e793c0da01361d9a660ee23586c27610ad5..9dc05adca3c5e3070bb28a140a359678247c3dcd 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -1741,12 +1741,13 @@ void RenderWidget::UpdateTextInputState(ShowIme show_ime,
}
#endif
-void RenderWidget::GetSelectionBounds(gfx::Rect* focus, gfx::Rect* anchor) {
+bool RenderWidget::GetSelectionBounds(gfx::Rect* focus, gfx::Rect* anchor) {
WebRect focus_webrect;
WebRect anchor_webrect;
webwidget_->selectionBounds(focus_webrect, anchor_webrect);
*focus = focus_webrect;
*anchor = anchor_webrect;
+ return true;
}
void RenderWidget::UpdateSelectionBounds() {
@@ -1756,9 +1757,9 @@ void RenderWidget::UpdateSelectionBounds() {
return;
ViewHostMsg_SelectionBounds_Params params;
- GetSelectionBounds(&params.anchor_rect, &params.focus_rect);
- if (selection_anchor_rect_ != params.anchor_rect ||
- selection_focus_rect_ != params.focus_rect) {
+ if (GetSelectionBounds(&params.anchor_rect, &params.focus_rect) &&
+ (selection_anchor_rect_ != params.anchor_rect ||
+ selection_focus_rect_ != params.focus_rect)) {
selection_anchor_rect_ = params.anchor_rect;
selection_focus_rect_ = params.focus_rect;
webwidget_->selectionTextDirection(params.focus_dir, params.anchor_dir);

Powered by Google App Engine
This is Rietveld 408576698