content/browser/android/content_view_core_impl.h - Issue 300323005: Route selection bounds updates through the compositor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 300323005: Route selection bounds updates through the compositor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Defer selection updates until after compositor scheduling Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/output/selection_bound.h ('K') | « cc/trees/layer_tree_impl.cc ('k') | content/browser/android/content_view_core_impl.cc » ('j') | content/browser/renderer_host/render_widget_host_view_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_view_core_impl.h

diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h

index 269ac88443973362cedc8b467da532d2cd14b51e..3ac57aa7231cafb8d6e24769b765eb9beadb36e6 100644

--- a/content/browser/android/content_view_core_impl.h

+++ b/content/browser/android/content_view_core_impl.h

@@ -264,8 +264,12 @@ class ContentViewCoreImpl : public ContentViewCore,

InputEventAckState ack_result);

bool FilterInputEvent(const blink::WebInputEvent& event);

void OnSelectionChanged(const std::string& text);

- void OnSelectionBoundsChanged(

- const ViewHostMsg_SelectionBounds_Params& params);

+ void OnSelectionBoundsChanged(const gfx::PointF& anchor,

+ const gfx::PointF& focus,

+ int anchor_dir,

+ int focus_dir,

+ bool is_anchor_visible,

+ bool is_focus_visible);

void StartContentIntent(const GURL& content_url);