Route selection bounds updates through the compositor

content/renderer/gpu/render_widget_compositor.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/gpu/render_widget_compositor.h"
 
 #include <limits>
 #include <string>
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/synchronization/lock.h"
 #include "base/sys_info.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "cc/base/latency_info_swap_promise.h"
 #include "cc/base/latency_info_swap_promise_monitor.h"
 #include "cc/base/switches.h"
 #include "cc/debug/layer_tree_debug_state.h"
 #include "cc/debug/micro_benchmark.h"
+#include "cc/input/layer_selection_bound.h"
 #include "cc/layers/layer.h"
 #include "cc/output/copy_output_request.h"
 #include "cc/output/copy_output_result.h"
 #include "cc/resources/single_release_callback.h"
 #include "cc/trees/layer_tree_host.h"
 #include "content/child/child_shared_bitmap_manager.h"
 #include "content/common/content_switches_internal.h"
 #include "content/common/gpu/client/context_provider_command_buffer.h"
 #include "content/public/common/content_switches.h"
 #include "content/renderer/compositor_bindings/web_layer_impl.h"
 #include "content/renderer/input/input_handler_manager.h"
 #include "content/renderer/render_thread_impl.h"
 #include "gpu/command_buffer/client/gles2_interface.h"
 #include "third_party/WebKit/public/platform/WebCompositeAndReadbackAsyncCallback.h"
+#include "third_party/WebKit/public/platform/WebSelectionBound.h"
 #include "third_party/WebKit/public/platform/WebSize.h"
 #include "third_party/WebKit/public/web/WebWidget.h"
 #include "ui/gfx/frame_time.h"
 #include "ui/gl/gl_switches.h"
 #include "ui/native_theme/native_theme_switches.h"
 
 namespace base {
 class Value;
 }
 
 namespace cc {
 class Layer;
 }
 
 using blink::WebFloatPoint;
+using blink::WebSelectionBound;
 using blink::WebSize;
 using blink::WebRect;
 
 namespace content {
 namespace {
 
 bool GetSwitchValueAsInt(
     const CommandLine& command_line,
     const std::string& switch_string,
     int min_value,
     int max_value,
     int* result) {
   std::string string_value = command_line.GetSwitchValueASCII(switch_string);
   int int_value;
   if (base::StringToInt(string_value, &int_value) &&
       int_value >= min_value && int_value <= max_value) {
     *result = int_value;
     return true;
   } else {
     LOG(WARNING) << "Failed to parse switch " << switch_string  << ": " <<
         string_value;
     return false;
   }
 }
 
+bool ConvertWebSelectionBound(const WebSelectionBound& web_bound,
+                              cc::LayerSelectionBound* cc_bound) {
+  DCHECK(cc_bound);
+  if (!web_bound.layerId)
+    return false;

[aelias_OOO_until_Jul13, 2014/06/28 00:02:17]

Can we just DCHECK this instead?  The Blink API isn't a meaningful security
boundary that has to validate input.

[jdduke (slow), 2014/06/28 00:29:10]

Done, and I've already got ASSERT's in place on the (WIP) Blink side.

+
+  switch (web_bound.type) {
+    case blink::WebSelectionBound::Caret:
+      cc_bound->type = cc::SELECTION_BOUND_CENTER;
+      break;
+    case blink::WebSelectionBound::SelectionLeft:
+      cc_bound->type = cc::SELECTION_BOUND_LEFT;
+      break;
+    case blink::WebSelectionBound::SelectionRight:
+      cc_bound->type = cc::SELECTION_BOUND_RIGHT;
+      break;
+  }
+
+  cc_bound->layer_id = web_bound.layerId;
+  cc_bound->layer_rect = gfx::Rect(web_bound.edgeRectInLayer);
+  return true;
+}
+
 }  // namespace
 
 // static
 scoped_ptr<RenderWidgetCompositor> RenderWidgetCompositor::Create(
     RenderWidget* widget,
     bool threaded) {
   scoped_ptr<RenderWidgetCompositor> compositor(
       new RenderWidgetCompositor(widget, threaded));
 
   CommandLine* cmd = CommandLine::ForCurrentProcess();
@@ skipping 474 matching lines @@
           ? static_cast<const WebLayerImpl*>(outerViewportScrollLayer)->layer()
           : NULL);
 }
 
 void RenderWidgetCompositor::clearViewportLayers() {
   layer_tree_host_->RegisterViewportLayers(scoped_refptr<cc::Layer>(),
                                            scoped_refptr<cc::Layer>(),
                                            scoped_refptr<cc::Layer>());
 }
 
+void RenderWidgetCompositor::registerSelection(
+    const blink::WebSelectionBound& anchor,
+    const blink::WebSelectionBound& focus) {
+  cc::LayerSelectionBound cc_anchor;
+  cc::LayerSelectionBound cc_focus;
+  if (!ConvertWebSelectionBound(anchor, &cc_anchor) ||
+      !ConvertWebSelectionBound(focus, &cc_focus)) {
+    clearSelection();
+    return;
+  }
+
+  layer_tree_host_->RegisterSelection(cc_anchor, cc_focus);
+}
+
+void RenderWidgetCompositor::clearSelection() {
+  cc::LayerSelectionBound empty_selection;
+  layer_tree_host_->RegisterSelection(empty_selection, empty_selection);
+}
+
 void CompositeAndReadbackAsyncCallback(
     blink::WebCompositeAndReadbackAsyncCallback* callback,
     scoped_ptr<cc::CopyOutputResult> result) {
   if (result->HasBitmap()) {
     scoped_ptr<SkBitmap> result_bitmap = result->TakeBitmap();
     callback->didCompositeAndReadback(*result_bitmap);
   } else {
     callback->didCompositeAndReadback(SkBitmap());
   }
 }
@@ skipping 120 matching lines @@
   widget_->OnSwapBuffersAborted();
 }
 
 void RenderWidgetCompositor::RateLimitSharedMainThreadContext() {
   cc::ContextProvider* provider =
       RenderThreadImpl::current()->SharedMainThreadContextProvider().get();
   provider->ContextGL()->RateLimitOffscreenContextCHROMIUM();
 }
 
 }  // namespace content